Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the reuse of cached informers on creation by SharedInformerFactory. #3856

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable the reuse of cached informers on creation by SharedInformerFactory. #3856

wants to merge 1 commit into from

Conversation

Sud0x67
Copy link

@Sud0x67 Sud0x67 commented Jan 8, 2025 •
edited
Loading

This PR introduces a new constructor parameter, reuseExistingCachedInformer, to the SharedInformerFactory.

The aim is to facilitate the reuse of existing cached informers when creating informers through SharedInformerFactory.

Currently, SharedInformerFactory caches only the first informer created for each API type. Developers who wish to avoid creating a new informer each time must first call SharedInformerFactory#getExistingSharedIndexInformer before proceeding with creation.

By setting reuseExistingCachedInformer to true, SharedInformerFactory will automatically reuse existing cached informers instead of creating new ones. This approach simplifies the process and clearly indicates whether to utilize the cached factory, thereby reducing potential confusion.

The discussion can be found here Issue

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 8, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Sud0x67 / name: Sud0x67 (8973a20)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sud0x67
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @Sud0x67!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2025
@Sud0x67
Copy link
Author

Sud0x67 commented Jan 8, 2025

/test

@k8s-ci-robot
Copy link
Contributor

@Sud0x67: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Sud0x67
Copy link
Author

Sud0x67 commented Jan 8, 2025

@k8s-ci-robot /test

@Sud0x67
Copy link
Author

Sud0x67 commented Jan 8, 2025

@k8s-ci-robot /easycla

@Sud0x67
Copy link
Author

Sud0x67 commented Jan 8, 2025

@k8s-ci-robot /check-cla

1 similar comment
@Sud0x67
Copy link
Author

Sud0x67 commented Jan 8, 2025

@k8s-ci-robot /check-cla

@Sud0x67 Sud0x67 force-pushed the useCachedInformer branch from a9ecf71 to 8973a20 Compare January 8, 2025 13:20
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 8, 2025
@Sud0x67 Sud0x67 mentioned this pull request Jan 8, 2025
Open
@Sud0x67 Sud0x67 requested a review from brendandburns January 10, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yue9944882 yue9944882 Awaiting requested review from yue9944882

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sud0x67 @k8s-ci-robot @brendandburns